https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38854

--- Comment #2 from Jonathan Druart <[email protected]> ---
Created attachment 176292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176292&action=edit
Bug 38854: Remove 'class' property from ToolbarButton

New version of prettier fails on ToolbarButton because of (I guess) what it
thinks is a reserver keyword.

[error] koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue:
SyntaxError: Unexpected token, expected "{" (1:6)
[error] > 1 | class
[error]     |      ^

The error does not really make sense, the code is:
        class: {
            type: String,
            default: "btn btn-default",
        },

A solution could be to rename the property, but actually we never use another
value than the default one. The easiest seems to simply remove this property.

% prettier --version
3.4.2

Test plan:
Upgrade prettier (yarn add prettier), confirm you have a more recent
version
Try to tidy the file using
  `prettier koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue`

Without this patch you get the "Unexpected token" error.
With this patch apply you don't

Also rebuild the dist files using `yarn js:build` and confirm that the
buttons in the toolbar of the ERM and Preservation modules still appears
and are styled like before.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to