https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy <[email protected]> --- Hi Leo, Not sure if I am going to give you a first FQA. But just view it as a learning experience :) Two points of attention: [1] Invalid Replacement Price => Seems not in harmony with our current 'case policy'. Only first word needs uc? [2] Validation + if (!/^[0-9.]+$/.test(replacementprice)) { + var isValid = /^[0-9.]*$/.test(value); This allows for a price like ... Shouldnt we have some common way to check a monetary value ? How does Koha do that elsewhere? Too bad that HTML(5) does not seem to have a uniform way for doing this.. Similar question for $("input[name='items.replacementprice']").on("input", function () { Should we check on input or on change btw? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
