https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38868

            Bug ID: 38868
           Summary: numSearchResults and OPACnumSearchResults are not
                    sanity checked
 Change sponsored?: ---
           Product: Koha
           Version: Main
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]

It turns out that numSearchResults and OPACnumSearchResults are not sanity
checked.

If you have high numbers in these system preferences, your search results are
going to get very slow, and your browser may actually struggle to render the
large quantity of HTML. 

At a glance, we actually look up these sysprefs in more places than you'd
think... and since we use the "preference" function, we don't have an existing
way of doing sanity checks (either at setting time or getting time). 

--

I'd say the options look like building sanity checks into the "preference"
function, starting a Koha::Search object that can be used for getting search
information, or adding something into our current search classes (although that
might be too heavy weight for some contexts).

--

Due to the volume of system preferences, obviously adding sanity checks to all
system preferences could get unwieldy. But I reckon something needs to be done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to