https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38930
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Needs Signoff |In Discussion --- Comment #5 from Jonathan Druart <[email protected]> --- This looks good. Some remarks however: 1. Missing tests (at least for the new REST API endpoint, but it would be good to have some Cypress tests) 2. (wording) Wondering if "isUserPermitted" should not be closed to what we have in the module: has_permissions. What do you think? 3. About the endpoint, you named it /user_permissions There is a comment in the code: Koha/Patron.pm: flags => undef, # permissions manipulation handled in /permissions And in Koha/REST/V1/ERM.pm: 40 sub config { 49 # TODO Add permissions There are contradicting one another, but we discussed that when we implemented /erm/config and we agreed to have the logged in user's info embedded in this route. I think we should discuss 3. with Tomas. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
