https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650
--- Comment #26 from Emily Lamancusa (emlam) <[email protected]> --- Testing notes for 2nd patch: There are two modals that trigger the outer block of code affected by the patch (if ( $query->param('reserve_id') && $op eq 'cud-affect_reserve')): hold-found1 - modal appears when the checked-in item is already waiting for a hold hold-found2 - modal appears if the checked-in item can fill a hold, the hold is NOT already waiting (but it may be already in-transit), and there are no recalls on the item hold-found1 has a button to cancel the hold, which triggers the if($cancel_reserve) block. All other buttons on hold-found1 and hold-found2 would then trigger the else block. I tested the different buttons on both modals under various circumstances: - one hold on the bib vs multiple holds on the bib - holds at the logged-in branch vs another branch - current vs future holds I noted that clicking "Ignore" on hold-found1 (when the hold is already waiting) caused the modal to continue popping up until I selected another option; however, this behavior is present on main as well. (Not sure it makes sense to even have an "Ignore" option when the hold is already waiting, but that's for a different bug...) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
