https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929

--- Comment #8 from Jonathan Druart <[email protected]> ---
(In reply to Tomás Cohen Arazi (tcohen) from comment #6)
> (In reply to Jonathan Druart from comment #5)
> > Do we want a test to enforce this?
> > 
> > Should we ALWAYS find $c->res->headers->location before the render call?
> 
> Well, we have a long time voted coding guideline
> 
> https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#REST3.4.1_POST

Yes, and it's not enough. Here is a test to enforce it, we have 3 failures.

    #   Failed test 'Koha/REST/V1/Auth/Password.pm does not contain the
location header'
    #   at xt/api.t line 186.

    #   Failed test 'Koha/REST/V1/Patrons/Account.pm does not contain the
location header'
    #   at xt/api.t line 186.

    #   Failed test 'Koha/REST/V1/Preservation/WaitingList.pm does not contain
the location header'
    #   at xt/api.t line 186.
    # Looks like you failed 3 tests of 55.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to