https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37918

Marcel de Rooy <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Status|Signed Off                  |Failed QA

--- Comment #21 from Marcel de Rooy <[email protected]> ---
This patch set raises a few questions:

[1] How is [% something | email_header %] supposed to work? Where does
email_header link to the EmailHeader module? I think this just returns nothing.
I would expect [% something| $EmailHeader %]
Since this was tested by two people, please explain. (No test plan in the third
patch.)

[2] Are you sure that you are doing the right thing here? We are in an HTML
context, not working with email headers directly but representing them in html.
Please clarify.
Why =?UTF-8?B?SGVsbG8gV29ybGQ=?= instead of Hello%20World for instance?
Should the script sending a mail subject to the html template be responsible?

[3] How do you prevent double encoding?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to