https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36025
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #23 from David Nind <[email protected]> --- I've attempted to test - everything works except the Selenium tests. They don't pass for me.[1] [1] Results from running the Selenium tests: prove t/db_dependent/selenium/patrons_search.t t/db_dependent/selenium/patrons_search.t .. 1/2 # Failed test 'there were no extended attributes on the search clause' # at t/db_dependent/selenium/patrons_search.t line 878. # got: '1' # expected: '0' # Looks like you failed 1 test of 2. # Failed test 'no clause for extended_attributes when none are default searchable' # at t/db_dependent/selenium/patrons_search.t line 880. # Looks like you failed 1 test of 3. t/db_dependent/selenium/patrons_search.t .. 2/2 # Failed test 'Search patrons in modal' # at t/db_dependent/selenium/patrons_search.t line 883. # Looks like you failed 1 test of 2. t/db_dependent/selenium/patrons_search.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- t/db_dependent/selenium/patrons_search.t (Wstat: 256 (exited 1) Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=2, 132 wallclock secs ( 0.03 usr 0.00 sys + 5.44 cusr 2.11 csys = 7.58 CPU) Result: FAIL [2] Testing notes (using KTD): 1. Start up KTD with Selenium: ktd --selenium up 2. Create two new patron attributes, without "Searchable" and "Search by default" set: . Administration > Patrons and circulation > Patron attribute types 3. Add some values for two new attributes to a couple of patrons, for example: . Attribute 1: ABC . Attribute 2: XYZ 4. Open the network testing tools using your browser's web developer tools. In Firefox, Menu > More tools > Web Developer Tools > Network. 5. Go to Patrons and do a search that returns multiple patrons, for example search for 'a'. 6. In the network tab, look for the <staffinterfaceurl>:8081/api/v1/patrons?_page=1.... request and note that there is a "extended_attributes.code" as part of the URL. 7. Apply the patch and restart everything (restart_all). 8. Update one of the attributes from step 3 so that "Searchable" and "Search by default" are set. 9. Repeat steps 5 to 6 and note that request now includes the "extended_attributes.code". 10. Search for "ABC" and the results should include the two patrons you set this value for. 11. Update the other attribute from step 3 so that "Searchable" and "Search by default" are set. 12. Search for "XYZ" and the results should include the two patrons you set this value for. 13. Check that the tests pass: . New Cypress tests: yarn cypress run --spec t/cypress/integration/PatronSearch_spec.ts . Selenium tests: prove t/db_dependent/selenium/patrons_search.t -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
