https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30027
Johanna Räisä <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Johanna Räisä <[email protected]> --- (In reply to Nick Clemens (kidclamp) from comment #0) > Currently the routine calls: > 585 my $outstanding_credits = > 586 exists( $params->{credits} ) > 587 ? $params->{credits} > 588 : $self->outstanding_credits->as_list; > 589 for my $credit ( @{$outstanding_credits} ) { > 590 $outstanding += $credit->amountoutstanding; > 591 } > > We should instead call: Koha::Account::Lines->total_outstanding on the > Resultlines in order to avoid floating point rounding errors > > > Currently we see some amounts for refunds Throwing a 500 error, and in > plack-error.log: > Amount to payout (81.98) is higher than amountoutstanding (81.98) I'm looking at a problem which relates to this, https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38972 Koha::Account::Lines->total_outstanding is calculating the outstanding little differently. I tried to replace $outstanding_credits with that in Koha::Account->payout_amount. In some cases the resultset is different, total_outstanding uses only amountoutstanding column and outstanding_credits uses also the amount column. Maybe these functions should be giving same results before total_outstanding could be used in the payout_amount function. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
