https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981

            Bug ID: 38981
           Summary: Local cover images failing to load in OPAC search
                    results
 Change sponsored?: ---
           Product: Koha
           Version: Main
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: OPAC
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]

It looks like bug 26933 might've broke OPAC local cover images in the search
results due to a possible race condition.

In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt around line 630
there is a window.load() call which runs
'wait_for_images(verify_cover_images)'.

If you're only using OPACLocalCoverImages, there is no wait, so
verify_cover_images() is called immediately. That function  removes the
.cover-image element if there are no images.

In the case of OPACLocalCoverImages, there are no images yet, so the element
gets removed.

Now there are no images yet because
'KOHA.LocalCover.GetCoverFromBibnumber(false);', the function which populates
the local cover image elements, hasn't even run yet. Note that it's called
within a $(document).ready() which is written lower than the window.load()


It's possible that different configurations would yield different results, if
they load different resources at different times, which could affect when the
handlers run. 

I've observed the above when using a fairly vanilla koha-testing-docker.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to