https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

--- Comment #121 from Katrin Fischer <[email protected]> ---

1) Terminology 

I know this is rather old code now a this has been filed in 2020 and the first
time set to NSO in the same year... but I wonder if not some of the reserves
could have been turned into holds to get us somewhat closer to the goal of
better more consistent terminology.

a) circulation rule value 

For example the circulation rules:

onshelfholds
holds_per_record
holds_per_day
opacitemholds

... and reservesallowed.
... and with this patch: expire_reserves_charge

b) GUI (fixed in follow-up)

We are not going to have reserve used in the GUI. 
Updated "Expire reserve charge" to "Expired hold charge"

2) Validate input (fixed in follow-up)

We have since added some validation on the circulation rules form.

3) Use $Price for display (fixed in follow-up)

We need to display the saved charge formatted.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to