https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350
--- Comment #23 from David Cook <[email protected]> --- Comment on attachment 177371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177371 Bug 36350: Add caching for Objects::find and Objects::search Review of attachment 177371: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36350&attachment=177371) ----------------------------------------------------------------- ::: Koha/Objects/Cached.pm @@ +67,5 @@ > + else { > + my @args; > + push(@args , $cond) if defined $cond; > + # Don't include if only contains "cache" key > + push(@args, $attrs) unless keys %{$attrs} == 1 && defined > $attrs->{cache}; As I note above, "cache" is actually an attribute that DBIx::Class actually uses for caching search results in a ResultSet, so I don't think we should meddle with it. I'm still not sold on this change overall, but you might want to think of a key like "koha_cache" to clearly differentiate it from DBIx::Class's "cache". -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
