https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38729

--- Comment #15 from David Cook <[email protected]> ---
I'm a bit curious why you changed the authorities() function in C4/Heading.pm
instead of filtering the output of authorities() in C4/Linker/Default.pm, but
it looks like that function isn't used anywhere but the linker, so that's
probably fine. 

--

I'm still a bit skeptical about this one, but after reading through everything
again... I suppose it's more likely to lead to a lack of links rather than
false links... so the risk should be low. 

That said, if a library has AutoCreateAuthorities enabled, this change could
potentially lead to duplicate authorities being created. That said, that's a
problematic system preference anyway.

--

I still think it would be wise to wrap this in a system preference, so that you
don't interfere with existing behaviour. I was tempted to mark Failed QA, but
I'll leave it for someone else to decide.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to