https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39076

David Cook <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #4 from David Cook <[email protected]> ---
So I was tempted to say this isn't really a Koha-ish way of doing things... but
it turns out that it is! 

It's already done heaps in C4/Heading.pm and C4/Matcher.pm

Normally, I think that we'd just store the
Koha::SearchEngine::Elasticsearch::Search object in $self (as an attribute of
Koha::SearchEngine::Search that is), but that would take more code. It might be
easier to understand for someone unfamiliar with "state", but it's less elegant
for sure.

While "state" seems like it could be abused in some scenarios, I think that
this one is a pretty reasonable place to use it.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to