https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39025
--- Comment #5 from Julian Maurice <[email protected]> --- Comment on attachment 177856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177856 Bug 39025: Use old_issue_id for issue details on patron account screens Review of attachment 177856: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=39025&attachment=177856) ----------------------------------------------------------------- The lines modified by the patch check for account.issue_id and account.old_issue_id and then use account.checkout Can't we simply check if account.checkout is defined ? (which should return undef if issue_id and old_issue_id are both null) ? Also, storing the result of account.checkout in a TT variable probably avoids several duplicate SQL queries as it's used multiple times. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
