https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
--- Comment #10 from Pedro Amorim <[email protected]> --- Hi Lari, your feedback and testing is very much appreciated. Thank you for looking. (In reply to Lari Strand from comment #6) > I'm getting error: DEV atomic update > /home/lmstrand/Koha25/installer/data/mysql/atomicupdate/bug_37893.pl > [14:58:31]: Bug 37893 - Move SIPconfig.xml to database > ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Can't create > table `kohacomm`.`sip_accounts` (errno: 150 "Foreign key constraint is > incorrectly formed") at /home/lmstrand/Koha25/C4/Installer.pm line 771 This was an oversight, I've corrected it (sip_institutions needs to be created before sip_accounts) and squashed to https://github.com/PTFS-Europe/koha/commit/c0937ae0b8644fd42c4b84687235407cfb29e73a (In reply to Lari Strand from comment #7) > We also have multiple sip config files on our server (under SIPconfig path) > that should be iterated through and the file locations are on a different > location where the atomicupdate is trying to find them. Maybe the path to > the SIPConfig files could be set and read from koha-conf.xml or something? This is an interesting use case, apologies for my ignorance but how exactly do you have this set up? i.e. how does Koha natively know that it needs to look for multiple files on a certain directory? (In reply to Lari Strand from comment #8) > Maybe the passwords could be obscured by ***** by default in the sip2 > accounts view and could be shown only when a "view password" button is > clicked or something for security reasons? I love this idea, this needs to be built into bug bug 38201 as a "password" type form field, on the framework, and then all modules would be able to use it, including this work here of course. (In reply to Lari Strand from comment #9) > "We also have multiple sip config files on our server (under SIPconfig path) > that should be iterated through" This could be difficult to do and managed > via the UI, so as a workaround combining our config files into one and > running just that sip server process would be an ok solution for us. Coming back to this, is your setup a custom thing or a Koha native thing? If Koha natively supports multiple SIPconfig.xml files then this work needs to consider that. I've not considered it because I'm not aware of it being possible but I'm not very knowledgeable in how SIP may or may not be configured. If this is something you have set up in a custom manner, then yes I think adapting your custom set up for when upgrading into this module is the best course of action. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
