https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434
--- Comment #28 from Marcel de Rooy <[email protected]> --- (In reply to Hammat wele from comment #27) > (In reply to Marcel de Rooy from comment #25) > > [2] Minor point. Feeis like the following code parts should be reversed: > > I don't understand why this code parts should be reversed we added like > asked (on comment #3) Hi Hammat, Reversed, not reverted. Misunderstanding? I think that you should first test for the missing param and throw an exception before testing the preference as mentioned in comment3 indeed. Note this is just a minor observation. Not important.. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
