https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39267
David Gustafsson <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #5 from David Gustafsson <[email protected]> --- In the first patch I moved the block where the stickyduedate session value is set if stickyduedate param or $restoreduedatespec is set (around line 737, at "# Restore adate if changed by holds and/or save stickyduedate to session) further up where the related template variable are set for clarity when reading the code. The only variable affected by this change is $duedatespec which is validated on line 217, and that validation should not fail if doesn't come from user input. So thought perhaps better to leave that block where it is for a more minimal patch and less risk of introducing new behavior. The reason for the current behavior is that even if $duedatespec is set to an empty string if the stickyduedate param is not present, it will still be reassigned the previous date in the block mentioned above, as $restoredduedate is assigned as: my $restoreduedatespec = $query->param('restoreduedatespec') || $duedatespec || $session->param('stickyduedate'); Before the session is cleared. I don't see how this makes any sense and as far as I is not correct. I originally felt the urge to try to clean up all the different assignments in a way that is easier to follow, but the current code relies on a lot of very subltle and opaque consequences of how these assignments are currently made and to do this without unintended consequences just to fix this isolated issue seems way out of scope for the current patch. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
