https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657
--- Comment #47 from David Cook <[email protected]> --- (In reply to Jonathan Druart from comment #46) > (In reply to Martin Renvoize (ashimema) from comment #40) > > (In reply to Jonathan Druart from comment #38) > > > This is nice but could be confusing. I would prefer an explicit way to > > > retrieve the extended attributes. > > > > > > patron.get_extended_attribute("attribute") > > > patron.extended_attributes.get("attribute") > > > patron.extended_attributes["attribute"] > > > > > > I don't think adding (black) magic for people writing template notices is > > > a > > > good idea. > > > > I talk about exactly that in comment #19. The general replies have been > > they prefer these as far as I can see. > > Ok but then we are now 2 to prefer something else, don't we? :D > > With this approach a clash is also possible with existing attributes (what > you also said already). Yeah, I think something like patron.smartcard is dangerous, because it's impossible to know what people will name their attributes. It would mean that we could never be 100% certain when adding a new column or method to the Koha::Patron object. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
