https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39327

--- Comment #1 from David Cook <[email protected]> ---
Created attachment 179301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179301&action=edit
Bug 39327: Add BOM to label CSV output and set output layer to UTF-8

This change adds a BOM to the label CSV output, so that
Excel properly recognizes the data as UTF-8.

It also sets the output layer to UTF-8, so that Text::CSV_XS library
always outputs UTF-8 even when it thinks a string might not be (see
below)

To reproduce:
1. Make a cataloguing record with the minimum requirements filled in
2. Set 100$a to Chödrön, Pema
3. Add an item with a barcode
4. Repeat this process but use 我爱你 for the 100$a

5. Create a new label batch
6. Add the item to the batch
7. Export using the defaults
8. click "Download as CSV"
9. Note that Chödrön appears correctly but the Chinese does not

Test plan:
1. Apply the patch and koha-plack --restart kohadev
2. Do the "To reproduce" plan
3. Note that both Chödrön and 我爱你 appear correctly
4. If you were to inspect the bytes, you'd see that the output is UTF-8
encoded after the patch while Chödrön before the patch is Latin-1 encoded
(ie ö when UTF-8 encoded is C3B6 and in Latin-1 it's encoded as F6)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to