https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #52 from Katrin Fischer <[email protected]> --- The easy part first: Fixed a small conflict in t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblio.t and adjusted number of tests. (In reply to Martin Renvoize (ashimema) from comment #51) > I added the missing unit tests for you Katrin, and they highlighted to me > that we need to pass a frameworkcode into the MarcSubfieldStructure find > call to get unique values.. I stuck to the pattern of using the default > framework but feedback on that would be good. > > I also not that 952 is a repeatable field.. I've not tested the > functionality here, but the tests prove that if we have multiple 952's in > the record and one is invalid we will let that one through so long as it's > after a valid one... > > Worth some consideration perhaps. I think assuming the default framework should be fine for now, although we might be able to do better down the line as you can configure the framework to use on import and for existing records they already have a framework assigned that could be used. @Pedro: Can you please open a separate bug report for this issue? If it makes sense we could also mention that limitation in the release notes. For the second issue identified I think it sounds like a follow-up might be in order, either here or on a separate bug, but preferably before release. It sounds like it could be highlighting an issue with the new +=head3 can_add_item_from_marc_record and ideally we should have an accompanying regression test. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
