https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39331
--- Comment #10 from Baptiste Wojtkowski (bwoj) <[email protected]> --- (In reply to Nick Clemens (kidclamp) from comment #9) > (In reply to Baptiste Wojtkowski (bwoj) from comment #8) > > Hi ! > > I'd love to see this functionality in next version, guarantors need a lot of > > improvements. > > However I don't like the idea of a silent fail of a so low level function. > > It looks like a feature that will bring very weird and hard to understand > > bugs. > > > > The behavior of guarantors is very weird here : it destroys the old > > relationship to create a brand new one. It should check if it makes sense, > > add_guarantors should throw an (caught) exception. > > What do you mean by silent fail here? Koha in the past has always silently > removed guarantors when category was switched, this patch just fixes that > broken behaviour Oh, didn't know it had always been done so, otherwise asking Koha to do something it cannot do should result in an error, and just returning without doing the action. Setting PQA -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
