https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344
--- Comment #10 from Victor Grousset/tuxayo <[email protected]> --- Comment on attachment 179763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179763 Bug 37344: (follow-up) to be squashed Review of attachment 179763: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37344&attachment=179763) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_37344.pl @@ +27,5 @@ > $dbh->do( > q{ > INSERT IGNORE INTO authorised_values (category, > authorised_value, lib) VALUES > + ('DISCHARGE_CANCELLATION','PATRON_MISTAKE', 'Patron > asked a discharge by mistake'), > + > ('DISCHARGE_CANCELLATION','PATRON_STILL_NEEDS_ACCOUNT','Administration > required a discharge however the patron still needs to use their account') Discharge.pm still has an occurrence of BORROWER_MISTAKE. (I'm not sure of there are other cases) ::: installer/data/mysql/en/optional/auth_val.yml @@ +334,5 @@ > authorised_value: "OPAC" > lib: "Cancelled from the OPAC user page" > + > + > + # Disharge cancellations => Discharge @@ +336,5 @@ > + > + > + # Disharge cancellations > + - category: "DISCHARGE_CANCELLATION" > + authorised_value: "PATRON_MISTAKE" If Discharge.pm requires PATRON_MISTAKE/BORROWER_MISTAKE. And if the dbrev adds it on existing installs. Then it's not consistent with being in optional/auth_val.yml Which then as implications on «You must define at least one authorized value for the category DISCHARGE_CANCELLATION» But it's not clear where the value of <select class="cancellation-reason" name="cancellation-reason" id="modal-cancellation-reason"> Is processed so all the above is influence by eventual changes. ::: installer/data/mysql/kohastructure.sql @@ +2873,4 @@ > `needed` timestamp NULL DEFAULT NULL, > `validated` timestamp NULL DEFAULT NULL, > `cancelled` timestamp DEFAULT NULL, > + `cancellation_reason`varchar(80) DEFAULT NULL COMMENT 'authorised value > CANCELLATION_REASON', CANCELLATION_REASON => DISCHARGE_CANCELLATION DISCHARGE_CANCELLATION is the AV category. So that's what is the most needed to know. To know where the values come from. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
