https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220
Nick Clemens (kidclamp) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Signed Off |Failed QA --- Comment #27 from Nick Clemens (kidclamp) <[email protected]> --- This looks good, just a few comments; 1 - The change in ImportBreedingAuth to prevent caching issues should have a comment to explain what this code is doing, we could improve this in the future, maybe clearing the cache wehn XLST for a source is changed, but that's another bug 2 - The Direct SQL should be avoided in ImportBreedingAuth and the test should use Koha::Import::Record objects -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
