https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644

Shi Yao Wang <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #34 from Shi Yao Wang <[email protected]> ---
(In reply to Emmi Takkinen from comment #33)
> Tested this and in staff interface everything works as intended. However
> tests to not pass, they throw following errors:
> 
> t/db_dependent/Patron/Borrower_PrevCheckout.t .. 152/170
> #   Failed test 'PostIssue: Same item, same patron [1]'
> #   at t/db_dependent/Patron/Borrower_PrevCheckout.t line 385.
> #          got: '0'
> #     expected: '1'
> 
> #   Failed test 'PostIssue: Diff item, same bib, same patron [1]'
> #   at t/db_dependent/Patron/Borrower_PrevCheckout.t line 385.
> #          got: '0'
> #     expected: '1'
> 
> #   Failed test 'patron, wants_check_for_previous_checkout,
> do_check_for_previous_checkout'
> #   at t/db_dependent/Patron/Borrower_PrevCheckout.t line 555.
> #          got: undef
> #     expected: '1'
> 
>     #   Failed test 'Check only one item if bibliographic record is serial'
>     #   at t/db_dependent/Patron/Borrower_PrevCheckout.t line 582.
>     #          got: '0'
>     #     expected: '1'
>     # Looks like you failed 1 test of 2.
> 
> #   Failed test 'Check previous checkouts for serial'
> #   at t/db_dependent/Patron/Borrower_PrevCheckout.t line 592.
> 
> #   Failed test 'no warnings'
> #   at /usr/share/perl/5.34/Test/Builder.pm line 193.
> # There were 73 warning(s)
> .....
> 
> And:
> 
> t/db_dependent/Koha/ItemTypes.t .. 1/19 
> #   Failed test 'item types should be sorted by translated description'
> #   at t/db_dependent/Koha/ItemTypes.t line 115.
> #          got: '14 vrk av'
> #     expected: 'a translated itemtype desc'
> 
> #   Failed test 'no warnings'
> #   at /usr/share/perl/5.34/Test/Builder.pm line 193.
> # There were 9 warning(s)

Strange. I just ran these 2 tests and they pass with no warnings.
Can we get a third input on this?

Putting back to Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to