https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38494
--- Comment #27 from Katrin Fischer <[email protected]> --- (In reply to Janusz Kaczmarek from comment #26) > (In reply to Katrin Fischer from comment #25) > > Some comments: > > > > 1) It appears this is a MARC21 only feature and it should be highlighted as > > such in the release notes and in the system preference description. > > > > 2) I think "no" should be 0 here? > > > > + default: no > > + choices: > > + 1: Do > > + 0: "Don't" > > > > Please review and follow-up. > > Thank Katrin for reviewing. I am not sure, tbh. In authorities.pref I just > followed a pattern from neighboring preferences. The default is expressed > there with yes/no (I am not sure what impact and where these defaults may > have -- in a fast code review I was not able to find any). > > As to the MARC21 note in preference description, I may add one, but again, > the twin systempreference ConsiderHeadingUse which I looked at when creating > this one does not mention MARC21. So in this case, shouldn't both rather be > corrected in a separate follow up? What do you think? Hmmm, I believe maybe the default was supposed to be used with the editor, but since we also add an entry to systempreferences it just default to the database value? I suppose we can ignore that then. I think adding a note to both would be great as a quick follow-up here if you don't mind! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
