https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911
--- Comment #93 from Jonathan Druart <[email protected]> --- 1. Todos IMO to make this ready we need to: a. Attach to this bug the patches that are about the islands concept b. Move to a branch the patches for the example b. Remove [contenthash] from the filenames 2. Question - Also, can you explain why do we need both .esm.js and .js files? 3. Confirm bug? There is something wrong I think, somewhere... I tried to test removing the contenthash and see which files were generated, on top of the example but with the last patches, and I get: ERROR in ./koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue?vue&type=style&index=0&id=060b00a6&scoped=true&lang=css (../../../../../../node_modules/vue-loader/dist/index.js??ruleSet[0]!./koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue?vue&type=style&index=0&id=060b00a6&scoped=true&lang=css) × Module parse failed: ╰─▶ × JavaScript parsing error: Expression expected ╭─[2:0] 1 │ 2 │ .modal { · ─ 3 │ position: fixed; 4 │ z-index: 9998; ╰──── The git log is: 2fce1bbd165 (HEAD) Bug 37911: (follow-up) Let style-, css-loader handle styles in Koha's Vue apps f0325f3235a Bug 37911: (follow-up) Tidy and remove leftover entry point for islands in first config block 472e8503bc9 Bug 37911: (follow-up) Remove webpack.config.js f0afb0a3e41 Bug 37911: (follow-up) Isolate yarn.lock changes 396442e8d13 Bug 37911: (follow-up) Allow for initialisation of islands on demand c10525beedb Bug 37911: (follow-up) Prevent resolution failure of dynamic imports when building in mode --production bcd6b19c98f Bug 37911: (follow-up) Move store initialisation into hydrate's idle callback 7b8bd7fec9b Bug 37911: (follow-up) Enable usage of dependencies 561ff807fcf Bug 37911: (follow-up) Scan for requested components in caller and lazy load 78e159d9001 Bug 37911: (follow-up) Use webpack import annotations for more concise chunk names 6732a1c5a20 Bug 37911: (follow-up) Experimental introduction of dynamic imports for code splitting 148c67f284a Bug 37911: (follow-up) Update to vue ^3.5.4, use vue's web component implementation instead 0f0779ace1d Bug 37911: (follow-up) Correct wishful thinking in displayed comment about changes to data-props 2c9b8c5925e Bug 37911: Prototype vue islands within static pages ef4d0aa5c58 (origin/main) Bug 39460: Fix koha-upgrade-schema when no DB change needed -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
