https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010
--- Comment #278 from Jonathan Druart <[email protected]> --- QA review 1. We really should move C4::Contracts to Koha::Acquisition::Contract[s] before. It does not make sense to use C4::Contracts from Koha::Acquisition. The module is pretty trivial to replace. 2. I had the feeling there was something wrong in Koha::Acq::Bookseller::to_api, I think it causes this bug: Edit a vendor, add 2 interfaces, `select * from aqbookseller_interfaces` Edit again, don't change anything, save, select again MariaDB [koha_kohadev]> select interface_id, vendor_id, password from aqbookseller_interfaces\G *************************** 1. row *************************** interface_id: 8 vendor_id: 2 password: 53616c7465645f5fb2f929cb1abe15d15f9a6c54e9b38977a8055ece428f2c75 *************************** 2. row *************************** interface_id: 9 vendor_id: 2 password: 53616c7465645f5f2919e4566b6dacdaf29690ff2193f006bd55e843cb6ee0ae 2 rows in set (0.001 sec) MariaDB [koha_kohadev]> select interface_id, vendor_id, password from aqbookseller_interfaces\G *************************** 1. row *************************** interface_id: 10 vendor_id: 2 password: 53616c7465645f5f0b3f2ebce9124cd14317d4fe111dd0aeedaf9532460e9e43 *************************** 2. row *************************** interface_id: 11 vendor_id: 2 password: 53616c7465645f5ffd9ed9b565602e77db7510110fde8cfb43af971d46aefa3f No changes expected, we should not add another id. 3. We lost the "Show" password link + <p><span>Password: <span class="password"><a href="#" class="show_password" data-plain-text-password="[% i.plain_text_password | html %]">Show</a></span></span></p> We discussed it previously, but I actually didn't notice that this is something we have currently. Need to be re-discussed maybe. We also had bug 34778 since then. 4. (In reply to Jonathan Druart from comment #205) > Koha/Schema/Result/Aqbookseller.pm > +__PACKAGE__->has_many( > + "aliases", > + "Koha::Schema::Result::AqbooksellerAlias", > > Why? > > We already have Koha::Acquisition::Bookseller->aliases, when is this used? Still valid. 5. Koha/REST/V1/Acquisitions/Vendors.pm 92 my $subscriptions = delete $vendor->{subscriptions}; 93 my $baskets = delete $vendor->{baskets}; 94 my $contracts = delete $vendor->{contracts}; Why? 6. Manual link This needs to be adjusted Koha/Manual.pm: 'acqui/supplier' => '/acquisitions.html#vendors', 7. DELETE /vendors/:id should use apiclient (acq.js) 8. acqui/booksellers | supplier We pass the idea 118 supplier => $booksellerid, But consider it a vendor object in the template: 12 [% tx("Search for vendor {vendor}", { vendor = supplier }) | html %] 35 <span>Search for vendor [% supplier | $HtmlTags tag='em' %]</span> 8. vendors.tt a. +<div id="__vendors"> is this "__" to avoid conflict? b. I don't think we need that: + [% SET columns = ['cardnumber','name','category','branch','action'] %] + [% PROCESS patron_search_modal columns => columns, modal_title => t("Select user") %] + [% PROCESS patron_search_js columns => columns, filter => erm_users, actions => ["select"], preview_on_name_click => 1 %] 9. store/vendors has config.edifact = false But we actually have more in the config: userPermissions, marcOrderAutomation, currencies, gstValues I think this should be moved to the config route anyway (bug 38930) 10. Contracts table on the vendor show view is not correctly styled: https://snipboard.io/QHdc8N.jpg 11. i18n problems in VendorList: + escape_str( + `${row.baskets.length} basket(s)` + ) + + escape_str( + `${row.subscriptions_count} subscription(s)` + ) + and missing escape_str + row.name + 12: 2 QA failures: FAIL acqui/booksellers.pl FAIL critic # Variables::ProhibitUnusedVariables: Got 1 violation(s). FAIL acqui/vendors.pl FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
