https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39464

Magnus Enger <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #180890|0                           |1
        is obsolete|                            |

--- Comment #10 from Magnus Enger <[email protected]> ---
Created attachment 180895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180895&action=edit
Bug 39464: Grey rows in tables not highlighting in yellow when they should

Because the CSS rule for turning odd-numbered rows grey is highly-specific
(tbody tr:nth-child(2n+1):not(.dtrg-group, .active, .ok) td:not(.bg-danger,
.bg-warning, .bg-info, .bg-success, .bg-primary)), it overrides the
.highlighted-row, .highlighted-row td rule that some tables use to turn the
background of a currently-selected row yellow, so highlighted-row needs to be
added to the lists of not().

Test plan:
 1. Without the patch, Cataloging - New from Z39.50/SRU, perform a search like
    Author smith which will return at least two results.
 2. On an even-numbered row with a white background, click MARC and note that
    the row is given a yellow background (either by increasing the size of the
    popup to peer around the preview, or by closing the preview, since the
    highlight persists).
 3. On an odd-numbered row with a grey background, click MARC and note that
    the row isn't given a yellow background
 4. Administration - Circulation and fine rules, if you don't already have at
    least two rules add one by just changing the Patron category in the edit
    row and Save
 5. On a row with a white background, click Edit and note that the background
    for that row is yellow
 6. On a row with a grey background, click Edit and note that the background
    remains grey, not yellow
 7. Apply patch, in ktd --shell yarn build (or in a sandbox Actions - Build
    CSS and JS), clear browser cache or shift+Reload the page
 8. Repeat steps 1-6, but this time note that you get the same yellow
    highlighted background for both odd and even rows.

Signed-off-by: Magnus Enger <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to