https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340
--- Comment #45 from Tomás Cohen Arazi (tcohen) <[email protected]> --- I re-did all the patchset because it wouldn't apply after the latest ILL changes. I tested it to work both in the staff interface and the OPAC. There are still this type of failures: ``` FAIL koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/thesis.inc FAIL valid_template ill_text_input_field: not found ``` Fixing them would require either: * Including `ill/backends/Standard/shared/form_input_helpers.inc` in each of them * Getting rid of the individual files per-type, and merging those forms into the main one (create.inc, both in OPAC and staff interface). The first one would mean including the helper .inc twice as it is already included (and used) and the `create.inc` level. The latter would imply a regression from Pedro's attempt to make things reusable (this patchset already had to split between OPAC and staff interface those files). My vote would be keeping it as-is. But I leave it to y'all to decide. I can do either. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
