https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39764, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37912 --- Comment #286 from Jonathan Druart <[email protected]> --- (In reply to Matt Blenkinsop from comment #282) > (In reply to Jonathan Druart from comment #281) > > > 4. Filtering: > > > http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor > > > "Showing 1 to 1 of 1 entries (filtered from 3 total entries)" > > > But you have no way to remove the filtering and see all vendors > > > It is the current behaviour in main, but at least we had "Search for > > > vendor > > > my vendor" in the breadcrumb > > > > Still valid, and this is confusing IMO. > > See 'Bug 38010: (QA follow-up) Stop breadcrumbs from keeping filters' for a > concept - allows us to reuse it for future breadcrumbs as well Great. Still not perfect however, IMO we need a way to reset the filters near the table. But it's a good start. We will see what end-users say. > > > > 6. http://localhost:8081/cgi-bin/koha/vendors/2 > > > Warning in the console: > > > [Vue Router warn]: Discarded invalid param(s) "vendor_id" when navigating. > > > > Still valid. > > This is still happening in all Vue apps - I'm not entirely sure why, needs > some deeper investigation Opened bug 39764. > > (In reply to Jonathan Druart from comment #277) > > > 11. We lost test on email and URI fields: > > > Account email: Please enter a valid email address. > > > > Email should be fixed with only `type="email"` however the URI check is > > still a problem. > > I've added the type - do you mean the URI field on the form for interfaces > or the email more generally? The 2 email fields (interface and contacts) are now solved with type="email". However we lost the URI check on "Company's details: Website". Not blocker, not considering it really important for now. > > New ones: > > 12. > > http://localhost:8081/cgi-bin/koha/acquisition/vendors/1 > > * Missing "Receive shipment" > > * Missing space "+New" > > https://snipboard.io/WpbPck.jpg > > Can't reproduce the first, Receive shipment shows for me - did you delete > the baskets for the vendor? Oops, yes I guess so! Forget that. > > 13. > > Edit a vendor, open 2 contact blocks. > > Tick all options for first contact, then tick all for second contact: > > => Two from the first contact are unchecked: https://snipboard.io/SLNiJI.jpg > > This is the expected behaviour as we should only have one primary contact of > each type - supplier.tt line 700 in main Indeed, it's confusing :D Sorry! Forget that as well. All good for me. I will do another round of code review and test tomorrow. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
