https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #19 from Katrin Fischer <[email protected]> --- 1) QA script FAIL koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc FAIL filters missing_filter at line 25 ([% SET islands = Asset.js("js/vue/dist/islands.esm.js").match('(src="([^"]+)")').1 %] <script src="[% islands %]" type="module">) missing_filter at line 28 ( import { hydrate } from "[% islands %]";) I fixed it with the automated script in a separate commit. Please check! 2) Question about permission check We have this here, which appears to be a bit of a double up on first glance - do we need this in order to over both TT and vue cases where the menu is used? + suggestionscreate="[% CAN_user_suggestions_suggestions_create | html %]" + suggestionsmanage="[% CAN_user_suggestions_suggestions_manage | html %]" + suggestionsdelete="[% CAN_user_suggestions_suggestions_delete | html %]" And then: + v-if=" + suggestionscreate || + suggestionsmanage || + suggestionsdelete || + isUserPermitted( + 'CAN_user_suggestions_suggestions_create' + ) || + isUserPermitted( + 'CAN_user_suggestions_suggestions_manage' + ) || + isUserPermitted('CAN_user_suggestions_suggestions_delete') + " + > -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
