https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545
--- Comment #11 from Martin Renvoize (ashimema) <[email protected]> --- I need a cataloguer to weight in here I'm afraid. I've used the operation of syncing this up in the Koha::Biblio method to do a deep dive back into it. I've noted all the changes explicitly in my commit message, and I'm not entirely sure they're all correct. For instance, I'm not really sure about the punctuation handling and I could see that possibly causing problems for others. I'm also not sure about the removal of subfield s handling.. maybe that needs more consideration. Finally.. I also found whilst updating unit tests, that the regular expression used for punctuation handling in the 245 work of the original patch doesn't catch trailing whitespace which doesn't feel entirely appropriate as in my findings 'as_string' adds such space. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
