https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747
--- Comment #27 from Lisette Scheer <[email protected]> --- Updated test plan to better account for holds queue vs between hold queue runs: Bug 20747: (follow-up) Fix hold queue to work with LocalHoldPriority Group options This fixes the holds queue and associated tests. I also updated the sql file to fix an issue and the LocalHoldsPriority tests to fix a typo. I'm working on final unit tests for the holds queue for all the options for QA but I wanted to get the queue changes ready for sign-off. UPDATED TEST PLAN This patch adds new options to the LocalHoldsPriority system preference to allow for the following options: 'None' the equivalent to 'Don't' pre-patch 'GiveLibrary' the equivalent to 'Do' pre-patch 'GiveLibraryAndGroup' Allows for checking the library first, then hold groups 'GiveGroup' Allows to prioritize within a group without prioritizing any library first. The included patches will update the preference in existing installations to maintain current behavior. To Test: BEFORE APPLYING THE PATCH /Tip/ I kept the following tabs open: -The holds screen (for suspending, checking order, etc) -Check in screen (can ignore holds to keep them all in place) -Holds to Pull with "All" for Libraries -System Preferences /Setup Groups and confirm current behavior/ 1. Set the following system preferences: -" LocalHoldsPriority " system preference to "Give" -"LocalHoldsPriorityPatronControl" to "home library" -"LocalHoldsPriorityItemControl" to "home library" 2. Create 2 Library Groups - Set them to be hold groups - I called mine group 1 & group 2 3. Add 2 libraries each to each group. - Group 1 - Centerville - Fairfield - Group 2 - Fairview - Franklin 4. Find a patron for each branch in the groups - Centerville - Changed 23529000035676 (Henry) - Fairfield - Changed 23529000050113 (Jordan) - Fairview - Changed 23529001000463 (Edna) - Franklin - 23529000121682 (Nicole) 5. Find a record with at least 2 items 6. If needed change the home and holding libraries so you have at least one item for each hold group - Centerville - 39999000000252 - Fairview - Changed 39999000000238 7. Place 2 record level holds for the record. - One for 23529000035676 (Henry) for pickup at Centerville (Priority 1) - One for 23529001000463 (Edna) for pickup at Fairview (Priority 2) 8. Check in 39999000000238. The hold popup should be for the second hold (Edna), not the first (Henry.) Ignore the hold 9. Set the "RealTimeHoldsQueue" system preference to "Enable" 10. Edit the record then save to trigger real time queue update 11. On the Holds Queue (submit after each set of changes): - Centerville should be for Henry - Fairview should be for Edna 12. Suspend all the holds 13. Edit the record to trigger real time queue update. 14. Set the "RealTimeHoldsQueue" system preference to "Disable" 15. Unsuspend holds /apply patch and confirm behavior still works/ 16. Apply patch 17. Rebuild the database then restart_all (in sandboxes it's an action, in ktd " dbic && updatedatabase && restart_all ") 18. Confirm that " LocalHoldsPriority " is set to "Give Library" 19. Repeat steps 8-15, behavior should be the same. / check library then library group setting/ 20. Change " LocalHoldsPriority " to "Give library then library group" 21. Set the following record level holds for the record in the following order: *You can add Jordan and Nicole's, then rearrange the order. - Pickup at Fairfield - 23529000050113 (Jordan) - Pickup at Franklin - 23529000121682 (Nicole) - Pickup at Centerville - 23529000035676 (Henry) - Pickup at Fairview - 23529001000463 (Edna) 22. Check in 39999000000252 - should try and fill to Centerville - 23529000035676 (Henry) 23. Check in 39999000000238 - should try and fill to Fairview - 23529001000463 (Edna) 24. Repeat steps 9-10 25. On the Hold Queue: - Centerville should be for Henry - Fairview should be for Edna 26. Repeat steps 12-15 27. Suspend the hold for 23529001000463 (Edna) 28. Check in 39999000000238 should try and fill to 23529000121682 (Nicole) (ignore the hold) 29. Repeat steps 9-10 30. On the Holds Queue: - Centerville should be for Henry - Fairview should be for Nicole 31. Repeat steps 12-15 / check library group setting / 32. Reset the holds to match step 15. 33. Change " LocalHoldsPriority " to "Give group" 34. Check in 39999000000252 - should try and fill to Fairfield (Jordan) (ignore the hold) 35. Check in 39999000000238 - should try and fill to Franklin (Nicole) (ignore the hold) 36. Repeat steps 9-10 37. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole 38. repeat steps 12-15 /check no priority / 39. Change " LocalHoldsPriority " to "Don't give" 40. Reset the holds to match step 21. 41. Check in 39999000000238 - Should fill to Fairfield (Jordan) (ignore the hold) 42. Check in 39999000000252 - Should fill to Fairfield hold (Jordan) (ignore the hold) 42. Repeat steps 9-10 43. On the Holds Queue: - Centerville should be for Jordan - Fairview should be for Nicole 44. Repeat steps 12-15 /Also check/ Item level holds behave as expected Different combinations of LocalHoldsPriorityItemControl and LocalHoldsPriorityPatronControl Sponsored by: Cape Libraries Automated Materials Sharing Sponsored by: Northeast Kansas Library System (NEKLS) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
