https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
Pedro Amorim <pedro.amo...@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Pedro Amorim <pedro.amo...@openfifth.co.uk> --- (In reply to John Vinke from comment #14) > Failed QA Hi John, thank you. > At step 4 it is unclear what value should be set in implementation field. I pushed a new commit that should address this: https://github.com/openfifth/koha/commit/871ed139317ea56799909b5af8190b15470a02ee Please let me know. > At step 6, nothing will import if you have created institutions, accounts, > etc. > > Can we please have a more detailed test plan that covers all of the patches? I agree. I've made the previous 2 test plan comments obsolete to avoid causing future confusion. I've updated the test plan on the last tests patch on the branch and also copied here on my previous comment. The revised test plan should no longer cause you to experience this, i.e. first creating manually then import through updatedatabase. However, updatedatabase not adding subsequent data is intentional, as the data being re-inserted will fail due to duplicate keys, but the 'INSERT IGNORE INTO' skips the error. Furthermore, because updatedatabase is intended to run at upgrade time, it is not expected to have database data at that point, only data in the SIPconfig.xml file. If you want to run updatedatabase multiple times to test different setups or SIPconfig.xml files, the data should be removed beforehand to avoid duplicate clashes: delete from sip_accounts; delete from sip_institutions; delete from sip_listeners; delete from sip_server_params; delete from sip_system_preference_overrides; -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/