https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29074
Martin Renvoize (ashimema) <martin.renvo...@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181249|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvo...@openfifth.co.uk> --- Created attachment 182180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182180&action=edit Bug 29074: Do not set default expiration date for hold if DefaultHoldExpirationdatePeriod is left blank If DefaultHoldExpirationdate is on and DefaultHoldExpirationdatePeriod is blank, the blank is treated as a zero and all holds are created with an expiration date of today. This patch changes expiration dates storing so that if DefaultHoldExpirationdatePeriod is left blank, expiration date is not set. Users are informed about this with a note in syspref. To test: 1. Set DefaultHoldExpirationdate on but leave DefaultHoldExpirationdatePeriod blank. 2. Add hold for patron. => Note that expiration date is set as today. 3. Apply this patch => Confirm following note is now added after sysprefs: "NOTE: If DefaultHoldExpirationdatePeriod is left blank default expiration date is not set." 4. Add new hold for patron. => Note that expiration date is not set. Also prove t/db_dependent/Hold.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: Andrew Fuerste Henry <and...@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvo...@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/