https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864

Owen Leonard <oleon...@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #182172|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleon...@myacpl.org> ---
Created attachment 182226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182226&action=edit
Bug 39864: Move save button back into form

The save button for automatic item modification rules got moved outside
of the form during the refactor for bug 38714. This happened because
the form was spread between two separate IF blocks that checked the same
condition, which is no longer allowed as of 38714.

This patch consolidates the conditional blocks and moves the submit
button back inside its form.

To test:
1. Go to Cataloguing > Item modifications by age
2. Click Add Rules, and then Add Rule to create a new rule
3. Fill in some reasonable values, for example:
   Age in days: 365
   Age field: items.itemlost_on
   Substitutions: items.withdrawn = 1
4. Click save
--> Nothing happens!
5. Apply patch, refresh, the page, and fill values in again if needed
6. Click save again
--> The rule is saved!
7. Confirm the Edit rules, Add rule, and Cancel buttons still work
    i. Click Edit rules
    --> The rule you just created should now be editable
    ii. Click Add rule
    --> A new form for a second rule should be added to the page
    iii. Click Cancel
    --> The change is cancelled and the page returns to "List of rules"
        view

Signed-off-by: Owen Leonard <oleon...@myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to