https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344
David Nind <da...@davidnind.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |da...@davidnind.com
Keywords| |release-notes-needed
--- Comment #30 from David Nind <da...@davidnind.com> ---
I've suggested some changes to the wording in a follow-up (see below for
details or review the diff).
Some comments:
1. After you generate the discharge in the staff interface, the table is not
shown. You need to select the "Discharges" tab to show it.
2. If you cancel the discharge, then generate the discharge again, it only
shows the latest discharge - the history is not shown.
3. Shouldn't the value in the field for "Reason for cancellation" (now "Reason
cancelled") be the authorized value's description, not the cancellation code?
Testing notes (using KTD):
1. Update the database: updatedatabase
2. Update the schema: dbic
3. Restart everything: restart_all
4. Set system preference "useDischarge" to allow.
5. Update the username and password for Henry so that you can log in to the
account on the OPAC.
Suggested changes to messages in the follow-up
----------------------------------------------
koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt
- "Confirm deletion" --> "Confirm cancellation" (everywhere else, including the
button, says "Cancel" instead of delete)
- Column heading for the table in discahrges: change from "Reason of
cancellation" ==> "Reason cancelled"
- <p>Are you sure you want to cancel this discharge ? Borrower will again have
right to check out books after this.</p>
==> <p>Are you sure you want to cancel this discharge? The patron will be
able to check out items again.</p>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
- <p>Reasons why a discharge can be cancelled</p>
==> <p>Reasons for cancelling a discharge</p>
installer/data/mysql/atomicupdate/bug_37344.pl
- 'Patron asked a discharge by mistake'
==> 'The patron asked for a discharge by mistake.'
- 'Administration required a discharge however the patron still needs to use
their account'
==> 'A discharge was required, however the patron still needs to use their
account.'
installer/data/mysql/en/optional/auth_val.yml:
- "Patron asked a discharge by mistake"
==> "The patron asked for a discharge by mistake."
- "Administration required a discharge however the borrower still needs to use
their account"
==> "A discharge is required, however the patron still needs to use their
account."
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
