https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40024
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182833|0 |1 is obsolete| | --- Comment #2 from David Nind <[email protected]> --- Created attachment 182892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182892&action=edit Bug 40024: Update requested_partners check Test plan, k-t-d, don't apply patch: 1) Enable ILLModule 2) Install a backend that does not provide the 'get_requested_partners' capability, e.g. the libkey lending tool (IncDocs) backend plugin: https://github.com/openfifth/koha-ill-libkey-lending-tool/releases/tag/v2.0.3 3) Restart plack $ koha-plack --restart kohadev 4) Create a new IncDocs ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=IncDocs 5) Add a DOI '123', a cardnumber '42' and any library. Click 'Make request'. 6) You should now be on the 'Manage request' page. Notice there's a '(0)' after the status 'New request'. This happens because '_backend_capability' method returns '0' if the backend does not implement the capability. The template checks for 'length', and length of '0' is '1'. 7) Apply patch. Refresh the 'Manage request' page. Notice the '(0)' is no longer shown. Additional testing, ensure no regression is added: 1) Edit the only ILL partner present in k-t-d: <staff_url>/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=16 2) Add a 'primary email'. Click 'Save'. 3) Do the same but for a Standard request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Add a type, a cardnumber '42' and any library. Click 'Make request'. 5) You should now be on the 'Manage request' page. Click 'Place request with partners'. Select the only one available 'FRL - Walker' and click 'Send email'. 6) Notice the status shows 'Requested from partners (<the_email_you_entered_in_step_2)'. This is the expected behavior and working as before. Signed-off-by: David Nind <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
