https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40062

--- Comment #3 from Tomás Cohen Arazi (tcohen) <tomasco...@gmail.com> ---
(In reply to Kyle M Hall (khall) from comment #2)
> 
> If we change the ORDER BY to "priority ASC, reserve_id ASC" I think it will
> behave more intuitively!

I just tried it with my patch and the results are similar. The big question
here is: what is the expected behavior? If I add 4 holds on the same item, with
priority=1. For me, if 1 is the highest, then it means the result should be:

* p=1 -> hold_4
* p=2 -> hold_3
* p=3 -> hold_2
* p=4 -> hold_1

i.e. the hold is inserted with the requested priority, and the existing ones
are shifted if required.

And if we had:

* p=1 -> hold_1
* p=2 -> hold_2
* p=3 -> hold_3

and we added `hold_4` with priority=2, I would expect the result to be:

* p=1 -> hold_1
* p=2 -> hold_4
* p=3 -> hold_2
* p=4 -> hold_3

Does it make sense? I got it wrong?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to