https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180

David Nind <da...@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes checking out,
      release notes|                            |checking in, and renewing
                   |                            |items for a patron where a
                   |                            |guarantor is required, and
                   |                            |they don't have one (where
                   |                            |the ChildNeedsGuarantor
                   |                            |system preference is
                   |                            |enabled).
                   |                            |
                   |                            |These actions
                   |                            |are now completed
                   |                            |correctly, and a warning
                   |                            |message is now shown on the
                   |                            |patron's page where a
                   |                            |guarantor is required and
                   |                            |they don't have one:
                   |                            |"System preference
                   |                            |'ChildNeedsGuarantor' is
                   |                            |enabled and this patron
                   |                            |does not have a
                   |                            |guarantor.".
                   |                            |
                   |                            |Previously:
                   |                            |-
                   |                            |checking items in or out
                   |                            |generated a 500 error
                   |                            |message, even though the
                   |                            |actions were successfully
                   |                            |completed
                   |                            |- attempting to
                   |                            |renew items generated this
                   |                            |message "Error: Internal
                   |                            |Server Error" and the items
                   |                            |were not renewed
                   |                            |- no
                   |                            |message was shown on the
                   |                            |patron page warning that
                   |                            |they needed a guarantor
                 CC|                            |da...@davidnind.com

--- Comment #10 from David Nind <da...@davidnind.com> ---
From my testing, everything seems to work as expected.

I've attempted a release note - feel free to improve it!

Testing notes (using KTD):
1. Step 1: Child type patron with no guarantor: Lisa Charles
2. Step 2: Changed patron category Patron (PT) so that 'Can be guarantee' is
set to 'Yes', use Mary Burton
3. Step 5: The column name is lastseen, not datelastseen, so the correct SQL to
run is: UPDATE borrowers SET lastseen = '2025-01-01';
4. Step 7: I get a 500 error when attempting to check out the item, if I look
at the patrons page again the item is actually checked out to them (tested for
both Lisa and Mary)
5. Step 8: I get a 500 error when attempting to check in the item, if I look at
the the patrons page again the item was checked in (tested for both Lisa and
Mary)
6. Step 9: I get an "Error: Internal Server Error" in a yellow information box
at the top of the patrons page when trying to renew the item.
7. After the patch: Creating a patron in the Kid category (category type =
Child) or a patron category where "Can be guarantee" (Patron > Category type =
"Adult"), and don't add a guarantor - you get this message:
    The following fields are wrong. Please fix them.

    A child patron needs a guarantor.
8. Error updating patron's last seen date - there are two H3 headings: H3
heading, the title check in message is also an H3:
   Check in message <--H3
   39999000001396: Philippics.

   Error updating patron's last seen date <-- H3 as well
   The item has been checked in, but the issue below must be corrected:
   The system encountered an error when updating the patron's last seen date:

   [Child patron needs a guarantor]
9. Tests pass: prove t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to