https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39971
David Nind <da...@davidnind.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #182740|0 |1
is obsolete| |
--- Comment #6 from David Nind <da...@davidnind.com> ---
Created attachment 183088
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183088&action=edit
Bug 39971: Move patron_attributes_form method to a class
This makes it reusable, documentable, and testable.
This is changing code without adding a new feature or fixing a bug.
The first test plan should be to just make sure that the existing functionality
is kept intact, i.e. rendering and saving the patron attribute types in the
form.
As to why we need this, we're maintaining the ILL Actions plugin where we have
a feature to quickly add a patron. This is designed to be as minimal as
possible, but if there are any mandatory patron attribute types, those need to
be considered.
To test this:
1) Apply patches and enable ILLModule syspref.
2) Install the plugin:
https://github.com/openfifth/koha-plugin-ill-actions/releases/tag/v2.4.0
3) Add a mandatory patron attribute type, you can edit the existing one in
k-t-d, visit:
<staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attribute_type&code=SHOW_BCODE
5) Tick the 'Staff interface mandatory' checkbox
6) Create a new ILL request, visit:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
7) Notice there's a '+Add new user' link next to the cardnumber input at the
bottom of the form. Click that.
8) Notice there's a 'Additional attributes and identifiers' section. This is
only possible (without writing it again) because of the patches here.
Signed-off-by: David Nind <da...@davidnind.com>
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
