https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956
Lisette Scheer <lise...@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Lisette Scheer <lise...@bywatersolutions.com> --- Great start! I'm glad to see this is moving. A few issues: The action log should also follow the coding guideline for the diff column: https://wiki.koha-community.org/wiki/Coding_Guidelines#ACTN1:_New_additions_to_actions_logs_should_use_the_JSON_Diff_format Per Comment 10 it shouldn't be toggleable, so it should not follow the borrowers log sys pref. Additionally only the top level permissions are saved, not if there are changes to subpermissions. You'll get something like this: { "flags" : { "after" : 32, "before" : 32 } } Please see also the discussion in comments 14-17 about how those flags/subpermissions should ideally display as readable versions instead of just numbers that need to be decoded. I'm really excited about this getting some movement. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/