https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40275
David Cook <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #12 from David Cook <[email protected]> --- (In reply to Aleisha Amohia from comment #11) > This is a great fix. There's still quite a few more places in the codebase > that use Koha::Patrons->find and pass in the userid or cardnumber. I started > listing them all and then there were heaps and heaps ... and from what > you've said here, they'll all cause those errors/warns. I feel like they > should be addressed within this patchset even though I realise that creates > a lot more work - otherwise it ends up being one of those situations where > we have the old bad code in place at the same time as the new good code. > > I'll set this to Failed QA because of the other instances where I think this > needs to be implemented all at once, but happy to hear your thoughts. Do you have some examples of some other places? There are a number of places where I think we should actually be moving to using borrowernumber instead of cardnumber/userid, so some places might need that fix instead of this one? (For example bug 34018 or bug 39535) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
