https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682
--- Comment #7 from David Cook <[email protected]> --- Comment on attachment 183844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183844 Bug 32682: Add permission for viewing patron reading history Review of attachment 183844: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32682&attachment=183844) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_32682_add_permission.pl @@ +24,5 @@ > + # SELECT borrowernumber, 10, 'view_checkout_history' FROM > user_permissions WHERE code = 'remaining_permissions' > + # } > + # ); > + > + # TODO: migrate libraries' "intranetreadinghistory" syspref (will > this require us to not fully remove it until we're sure everyone has migrated > off of it?) This is an interesting question. Technically, I think that you have to keep the intranetreadinghistory because it's impossible to replace it with permissions only. For instance, maybe you disable intranetreadinghistory via Apache configuration because you don't want anyone - even superlibrarians to be able to read the checkout history. If you have libraries with intranetreadinghistory turned off, then these patches will actually cause a regression where anyone with all borrowers permissions will be able to see the reading history when they couldn't previously. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
