https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657
Michael Hafen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184063|0 |1 is obsolete| | --- Comment #32 from Michael Hafen <[email protected]> --- Created attachment 184064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184064&action=edit Bug 28657: expand branches.branchip to allow for multiple ip ranges. [ QA follow up, now with more typo fixes ;) ] change branches.branchip to a mediumtext, and remove '*' from existing branchip settings. Change C4/Auth.pm from a regexp to using in_iprange() to check client address ag ainst branchip. (in_iprange() doesn't work with '*' in branchip.) Change in_iprange() to default to false (which is what the POD says it should do ). Also, have it trim '*' in case someone adds some back later. Change tests to account for new default, and add a test for '*'. Change note in admin/branches.tt under branchip field to reflect changes to bran chip handling. Test plan: 1. Turn on AutoLocation system preference 2. Change a branches branchip to multiple ip ranges seperated by a space, making sure one of the ranges includes your computers address. 3. Log out and try logging in. The location check will fail. 4. Apply patch. Restart plack if necessary. 5. Try logging in again. The location check will succeed. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
