https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40541
Owen Leonard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184791|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <[email protected]> --- Created attachment 184794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184794&action=edit Bug 40541: Add missing new line at the end of files when missing We have insert_final_newline = true to ensure files will contain a new line at the end. However we have seen commits with "No new line" added in the git log. We should have a xt test to prevent more occurrences. We should also have a test at the QA script level: https://gitlab.com/koha-community/qa-test-tools/-/issues/96 Test plan: prove xt/find-missing-new-lines-at-the-end-of-file.t should return green. Remove the new line at the end of a file, eg. vim -b mainpage.pl :set noeol :wq Now prove xt/find-missing-new-lines-at-the-end-of-file.t is failing on mainpage.pl. Signed-off-by: Owen Leonard <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
