https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40554
--- Comment #7 from Jonathan Druart <[email protected]> --- (In reply to David Cook from comment #6) > (In reply to Jonathan Druart from comment #4) > > Is it worth investing more time in this? Who supports this idea? > > On the surface, it sounds like a good idea. > > As for investing time, I'm not 100% sure. Personally, I find it difficult to > test bugs like this, because they make a lot of changes all at once, so it > feels overwhelming trying to test them. Yes it's not the kind of patches we should test all the occurrences. There are only few different patterns (here mostly is: opac or not, default to blank or not, and that's all. If you test a couple of each then a code review is enough. > If this bug introduced the caching mechanism, added some unit tests, and > then changed one or two places and had a detailed test plan, then it would > feel doable testing it, and then follow-up reports could be added for other > .pm/.pl files which depend on this report. > > Does that answer the question? The caching mechanism is already half implemented. The idea here is to adjust and reuse it for the different AV fetches. I don't like the 1 bug report per file pattern for this kind of changes: it always ends up half done, and it's hard to review. Especially when we change something in the middle of the tree and we need to adjust what has been done already. That and the dependency tree that is a nightmare to maintain. However we can implement the concepts incrementally: start with find_description, then replace search with find, add caching mechanism for single fetches, implement L2 when only L1 is used, etc. But here we are not really talking about huge changes in term of diff :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
