https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
Aleisha Amohia <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #126 from Aleisha Amohia <[email protected]> --- (In reply to Pedro Amorim from comment #103) > Have signed-off as the observations I'm listing below are minor and quickly > fixable (adding the ones from comment #92 here to have them all in a single > comment): > > 1) > In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt > > We have > IF Koha.Preference('UseRecalls') != "off" > > Should it not be > IF Koha.Preference('UseRecalls').match('opac) > > i.e. do we want to show this on this template if UseRecalls = 'staff'? Thanks for checking, yes we still want it there to show recalls on their account that were requested via the staff interface, even if the user couldn't request it themselves via the OPAC. > > 2) > In opac-recall.pl: > Shouldn't the check for if($op eq 'cud-cancel) be inside the if ( > C4::Context->preference('UseRecalls') =~ m/opac/ ) check? > Similar to the above response - the cud-cancel being outside the UseRecalls check means they can still cancel recalls that were requested on their behalf via the staff interface. So this is intentional also. > 3) > Occurrences of: > <input type="submit" class="btn btn-default" value="Place recall"> > Should be using .btn-primary Thanks, will address in a follow-up > > 4) > I believe occurrences of: > div class="dialog alert" > Should be > div class="alert alert-warning" Thanks, will address in a follow-up > > 5) > At first it seems recalls_per_record was buggy as I had it configured as 5 > but was placing 10 recalls on a biblio record. I then realized 'record' in > recalls_per_record refers to the patron record (?) and is consistent with > the other circulation rules. Yes that's right, the rule limits how many recalls a patron may request on one record, and does look to be working as intended. > > 6) > Bug 23269 should be rebased on this or vice-versa. > I believe recalls API endpoints will be needed for bug 23269. I think that would be handled separately - this bug report is building upon existing recalls functionality to enable recalls requested via the staff interface, so new endpoints would be out of scope. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
