https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631
--- Comment #55 from Casey Conlin <[email protected]> --- (In reply to Lucas Gass (lukeg) from comment #54) > Hi Casey, > > Tests are failing here, can you have a look? > > t/db_dependent/Koha/Reports.t Hi, Lucas, thanks for taking a look here! When you ran the test command, were you in ktd shell? I omitted that step from my the test plan. run: ktd --shell kohadev-koha@kohadevbox:koha(16631-reports-libraries-filter-patch)$ t/db_dependent/Koha/Reports.t 1..10 ok 1 - Adding a new report should have set the id ok 2 - The 2 reports should have been added ok 3 - Find a report by id should return the correct report ok 4 - Delete should have deleted the report # Subtest: prep_report 1..4 ok 1 - Expected sql generated correctly with single param and name ok 2 - Expected sql generated correctly with multiple params and names ok 3 - Expected sql generated correctly with multiple params and no names ok 4 ok 5 - prep_report # Subtest: is_sql_valid 1..15 ok 1 - Empty sql is missing SELECT ok 2 - Nonsense sql is missing SELECT ok 3 - select FOO is good ok 4 - select FOO with UPDATE BAR ok 5 - UPDATE qux ok 6 - select FOO with DELETE BAR ok 7 - DELETE qux ok 8 - select FOO with DROP BAR ok 9 - DROP qux ok 10 - select FOO with INSERT BAR ok 11 - INSERT qux ok 12 - select FOO with SHOW BAR ok 13 - SHOW qux ok 14 - select FOO with CREATE BAR ok 15 - CREATE qux ok 6 - is_sql_valid # Subtest: check_columns 1..3 ok 1 - Bad column found in SQL ok 2 - No bad column found in SQL ok 3 - Check column_names parameter ok 7 - check_columns # Subtest: _might_add_limit 1..10 ok 1 - Pref is undefined, no changes ok 2 - Pref is zero, no changes ok 3 - Pref is empty, no changes ok 4 - Limit 10 found at the end ok 5 - Already contains a limit ok 6 - Variation, also contains a limit ok 7 - Subquery, limit 10 found at the end ok 8 - Subquery variation, limit 10 found at the end ok 9 - Subquery lc variation, limit 10 found at the end ok 10 - Query refers to limit field, limit 10 found at the end ok 8 - _might_add_limit # Subtest: reports_branches are added and removed from report_branches table 1..4 ok 1 - 3 branches added to report_branches table ok 2 - 1 branch removed from report_branches table ok 3 - Report deleted, count is back to original ok 4 - No branches left in reports_branches table after report deletion ok 9 - reports_branches are added and removed from report_branches table ok 10 - no warnings -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
